Feature/#37 delimiters configuration#50
Open
b3b00 wants to merge 10 commits intovalyala:masterfrom
b3b00:feature/#37-delimiters-configuration
Open
Feature/#37 delimiters configuration#50b3b00 wants to merge 10 commits intovalyala:masterfrom b3b00:feature/#37-delimiters-configuration
b3b00 wants to merge 10 commits intovalyala:masterfrom
b3b00:feature/#37-delimiters-configuration
Conversation
tag delimiters must be :
- 2 characters
- 2nd of start delimiter and 1st of end delimiter must be identical eg [% %] but not [{ }] where { <> }
…miter) qtc arguments
Author
|
tested successfully with the basic server example :
|
Author
|
Hello @valyala , did you consider my pull-request ? I am aware that the implementation is not perfect. |
Owner
|
@b3b00 , what is the use case for custom delimiters? Custom delimiters may fragment and complicate the experience with |
Author
|
This PR answers issue #37 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows to configure starting an ending tag delimiters (default "{%" and "%}" accordingly)
2 arguments have been added to the qtc compiler :
-sTag '{%'-sTag '%}'Delimiters mus respect following rules :
These rules are for compatibility reasons with original templates parsing.